Node List with filters, backend structure (dummy data) #3
Conversation
There was a problem hiding this comment.
Everything looks good to me, except that perhaps we shouldn't postpone setting up the proper CI checks of the Python codebase. Even this PR contains PEP8 violations (attributes and variables named in camel case instead of snake case) and there are missing type annotations. Without type annotations, code maintenance will get difficult fast with bugs galore. This PR is fine to merge but I urge you to get these things organized before we started any serious coding here.
|
Of course, this is why the backend structure PR exists. I am now working on the linting an tests for the backend. |
|
The online swagger editor is particularly nice: Check the swagger doc out It also provides mock api responses if someone wants to test quickly. Example of node list |
@pavel-kirienko does this look good for the backend?
I've yet to come up with a proper python project structure, but do you like this approach?
Nodes List at frontend is ready (never mind the initial data on the state, these are for testing when the server is offline).
As soon as I'm sure you like this UI, I'll write unit and e2e tests as well.
The Home (Node list) component rendering is based on it's state so the auto update-refresh logic can be added later as an addition, without breaking existing features, pretty effortlessly.