This repository has been archived by the owner on Mar 7, 2022. It is now read-only.
correct issue where fast firmware uploads could retry #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
suggested changes
Jul 22, 2017
| success() | ||
|
|
||
| def on_node_status(e): | ||
| if e.transfer.source_node_id == self._target_node_id and e.message.mode == e.message.MODE_SOFTWARE_UPDATE and e.message.health < e.message.HEALTH_ERROR: |
There was a problem hiding this comment.
Lines should not be longer than 120 characters, this one is noncompliant. See https://kb.zubax.com/x/_oAh
| @@ -305,6 +333,7 @@ def send_request(): | |||
| except Exception as ex: | |||
| show_error('Firmware update error', 'Could not send firmware update request', ex, self) | |||
|
|
|||
| node_status_handle = self._node.add_handler(uavcan.protocol.NodeStatus, on_node_status) | |||
There was a problem hiding this comment.
Who removes the handle in the event of an unsuccessful completion or a timeout?
pavel-kirienko
approved these changes
Jul 26, 2017
|
Thanks @jschall |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.