Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abbyy2hocr transformation by @OCR-D #92

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

zuphilip
Copy link
Member

I did not yet test it, but it looks straightforward.

Copy link
Contributor

@jmechnich jmechnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason why it should not be included here but after actually testing it, I am not very impressed with the results as a) it does not produce valid output from our ABBYY files and b) it requires a few mandatory parameters that are not always available. Maybe including it in ocr-fileformat will increase the visibility of the transformation so that those shortcomings can be remedied.

@kba
Copy link
Collaborator

kba commented Sep 23, 2019

Maybe including it in ocr-fileformat will increase the visibility of the transformation so that those shortcomings can be remedied.

Can you open issues at https://github.com/OCR-D/format-converters/issues lest we forget @jmechnich? Thank you

@zuphilip
Copy link
Member Author

@kba Yes, thank you for the suggestion. That is what we discussed last Friday and I said that I will do that. We also discussed that at least the required parameters should be make optional for the integration here, because otherwise it might not be possible to use that in the GUI.

@zuphilip
Copy link
Member Author

Here is a PR for making the parameters optional: OCR-D/format-converters#8

@zuphilip
Copy link
Member Author

zuphilip commented Oct 2, 2019

The upstream PR is merged now. @jmechnich Can you test the new version where the parameters are not mandatory anymore? Is this now giving results in the GUI?

@jmechnich
Copy link
Contributor

jmechnich commented Oct 4, 2019

Upstream is already broken by another commit. :)
Actually, maybe we should consider using git submodules or a specific commit for the vendor packages in vendor/Makefile as this is not the first time sth like this happened.

@zuphilip
Copy link
Member Author

zuphilip commented Oct 4, 2019

Here is PR for fixing the newly introduced regressions OCR-D/format-converters#11

BTW I would love to see also some tests integrated with CI in the upstream repo.

@zuphilip
Copy link
Member Author

Okay, upstream is merged now again. @jmechnich Can you give it a try again? 🙏

@stweil stweil merged commit 333731e into UB-Mannheim:master Dec 27, 2019
@zuphilip zuphilip deleted the abbyy2hocr branch December 27, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants