Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed dependencies incompatible with windows and added altair vega-… #59

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

salva-u
Copy link
Collaborator

@salva-u salva-u commented Apr 5, 2024

added altair
dash-vega-components

@salva-u salva-u linked an issue Apr 5, 2024 that may be closed by this pull request
@salva-u salva-u self-assigned this Apr 5, 2024
@salva-u salva-u added the bug Something isn't working label Apr 5, 2024
@salva-u salva-u added this to the Milestone 2 milestone Apr 5, 2024
Copy link
Collaborator

@AReyH AReyH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't think we are using Altair anymore, right?

@salva-u
Copy link
Collaborator Author

salva-u commented Apr 5, 2024

Looks good, but I don't think we are using Altair anymore, right?
this code chunk still uses it, I merged the test_app and app into one, I might have kept the older version in? or not sure this is referenced later or not, don't wanna remove it and break things, let's just keep it?
python race_pol_party_chart1 = alt.Chart(df_pct).mark_bar().encode( x=alt.X('race', axis=alt.Axis(title='Race')), y=alt.Y('percentage:Q', axis=alt.Axis(format='%'), stack='normalize', title='Percentage'), color=alt.Color('political_party', legend=alt.Legend( title='Political Party')) ).properties( title='100% Stacked Bar Chart of Political Party by Race' )
@AReyH

Copy link
Collaborator Author

@salva-u salva-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comment regarding altair

@salva-u salva-u requested a review from AReyH April 5, 2024 17:36
@AReyH
Copy link
Collaborator

AReyH commented Apr 5, 2024

I can check in a bit, but I deleted the Altair graph, because I replicated it with Plotly. I'll check and see if we're using Altair.

@salva-u
Copy link
Collaborator Author

salva-u commented Apr 5, 2024

let's do that on a different branch, we can merge the current to PRs, if everything is good, and you can create a new issue for altair fix?

Copy link
Collaborator

@Sampsonyu Sampsonyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salva-u salva-u merged commit 5690b44 into main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the environment file
3 participants