Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 Feedback #45

Open
3 tasks
negsadr opened this issue Mar 5, 2023 · 0 comments
Open
3 tasks

Milestone 1 Feedback #45

negsadr opened this issue Mar 5, 2023 · 0 comments

Comments

@negsadr
Copy link

negsadr commented Mar 5, 2023

Congratulations on finishing milestone 1! We can see you put a lot of work into this project, nice work!
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.


Submission instructions

rubric={mechanics:4}

Well done!

Section 1: Motivation and Purpose

rubric={reasoning:8,writing:2}

Well done!

Section 2: Description of the data

rubric={reasoning:8,writing:2}

  • proposal.md - Dataset description section: The level of description is the dataset is very general and it is not focusing in the variables that are important for the analysis. -1 reasoning

  • proposal.md - Dataset description section: There is not evidence data quality analysis. Are there missing values? Are these values an important percentage of the dataset?. -1 reasoning

Comments:

  • Your description lacks analysis of the dataset specific to your project (tasks, target group, app…).

Section 3: Research questions and usage scenarios

rubric={reasoning:12,writing:2}

  • proposal.md - Persona: In the persona description it is not informed what is needed to visualize from the data -3 reasoning

Comments:

  • The persona explains clearly what the application provides for the user but not why it is beneficial.
  • It is not completely matching the milestone instructions. What could be improved is the progression of steps, starting from the problem of the user that is intended to be solved by the application.
  • Also please note that Persona is a scenario and does not need to necessarily include all the application features.

Section 4: Description of your app & sketch

rubric={viz:10, writing:2, reasoning: 3}

Well done!

Section 5: Team work contract and collaborative documentation

rubric={reasoning:4}

Well done!

Code of Conduct

rubric={reasoning:1}

Well done!

Contribution guidelines

rubric={reasoning:1}

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant