Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 4 Feedback #96

Open
ArmaghanSarvar opened this issue Mar 23, 2023 · 0 comments
Open

Milestone 4 Feedback #96

ArmaghanSarvar opened this issue Mar 23, 2023 · 0 comments

Comments

@ArmaghanSarvar
Copy link

Congratulations on finishing milestone 4! We can see you put a lot of work into this project, nice work! Below we list some specific feedback you can use to improve your project.

  • Submission instructions: mechanics: 4/4

  • Improving your app: mechanics: 20/20

o The information requested for the submission on Canvas is including what has been modified, the source, team member, and commit/s.
o There is one improvement to the application by each team member and the changes are not only minor fixes.

  • Reproducibility 20/20
    o Testing: rubric={mechanics:5/5, accuracy:5/5}
    • The tests are passing in the github action workflow 5/5
    • There are 3 test_that() statements in the file tests/testthat/test-shinytest2.R  5/5
    o Continuous Integration and Deployment: rubric={mechanics:5, accuracy:5}
    • There should be one workflow badge in the README.md 5/5 mechanics
    • The deployment workflow deploy_app.yaml is passing. 5/5 accuracy

  • Tie it all together: rubric={mechanics:20/20, accuracy:20/20, viz:6/10}
    o The main plots take time to load (-4)

  • Reflection: reasoning: 6/6
    o There is a reflection-milestone4.md file 
    o reflection-milestone4.md is included in the docs folder
    o When reviewing reflection-milestone4.md and comparing it with the milestone1 sketch, it's not difficult to comprehend the alterations that were made and the reasons behind them.  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant