Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 4 feedback #83

Open
ghost opened this issue Feb 16, 2021 · 0 comments
Open

Milestone 4 feedback #83

ghost opened this issue Feb 16, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 16, 2021

Hey Group 5,

Congrats on finishing up this project! Big improvement in layout this week, which is great to see! All your bugs seem to be remedied, save for one new one: rank is listed as negative for the bar graph. Overall, I think this turned out quite well! You chose a rather ambitious project, but managed to get it all functional. There are still a few minor points of improvement:

  • bar graph is a bit redundant with the table and color isn't great for small integer values like rank
  • color scale for the map would be better as a more linear scale (vs this rainbowy/diverging scale)
  • line plot legend could be placed outside the plot to avoid covering the lines when many countries are added
  • Also, as you mention in your reflection, data could be standardized across the years

All of that said, these things don't severely impact the usability of your app and I still think it would be very useful to your target audience.

Great job and good luck with the rest of your courses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants