Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proposal research question #1

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Conversation

adrianne-l
Copy link
Collaborator

No description provided.

@adrianne-l adrianne-l requested review from lipcai, zjr-mds and zackt113 and removed request for zackt113 February 15, 2022 04:47
Copy link
Collaborator

@zackt113 zackt113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some suggested changes, other than that, looks good to me! And the workflow is correct! Thanks!

docs/proposal.md Outdated Show resolved Hide resolved
docs/proposal.md Outdated Show resolved Hide resolved
@adrianne-l adrianne-l linked an issue Feb 15, 2022 that may be closed by this pull request
6 tasks
or (by genre) since the users can ignoring the genre filter

Co-authored-by: zackt113 <94644378+zackt113@users.noreply.github.com>
@lipcai
Copy link
Collaborator

lipcai commented Feb 15, 2022

looks good

docs/proposal.md Outdated Show resolved Hide resolved
adrianne-l and others added 2 commits February 14, 2022 22:09
Revise usage scenario

Co-authored-by: zackt113 <94644378+zackt113@users.noreply.github.com>
Co-authored-by: zackt113 <94644378+zackt113@users.noreply.github.com>
Copy link
Collaborator

@zjr-mds zjr-mds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you!

docs/proposal.md Outdated Show resolved Hide resolved
@zjr-mds zjr-mds merged commit 3b3cffe into dev Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone1 task checklist
4 participants