added sick packges, should have no need for dependencies #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethellis0
requested changes
Feb 4, 2017
There was a problem hiding this comment.
@Dulluhan This looks good, presuming that it runs fine on your system. Only thing is that if we're going to include submodules in the repo, the installation instructions will need to be changed accordingly. Basically, instead of git clone, we'll have to git clone --recursive to download the submodules on initial setup. Just make the change to the ReadMe in the setup section and we should be good!
garethellis0
approved these changes
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sick packages as submodules