Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate FreeKickPlay and KickoffPlay into OffencePlay #2798

Closed
2 tasks
itsarune opened this issue Jan 5, 2023 · 1 comment
Closed
2 tasks

Integrate FreeKickPlay and KickoffPlay into OffencePlay #2798

itsarune opened this issue Jan 5, 2023 · 1 comment
Assignees
@raymond212
Labels
Difficulty - 7 Well-defined tasks that requires some understanding about the relevant system and tools

Comments

@itsarune
Copy link
Contributor

itsarune commented Jan 5, 2023

Description of the task

In our current architecture, it's difficult to define clear transitions out of Kickoff and FreeKick into OffencePlay and becomes a bit arbitrary on when we transition to OffencePlay. So this ticket involves integrating KickoffPlay into OffencePlay so that we don't have to worry about this situation.

You can take a look at this closed PR for inspiration (or as a basis) #2695

Acceptance criteria

  • Integrate FreeKickPlay and CornerKickPlay into OffencePlay
  • Ensure current free kick play and corner kick play tests are passing (supplement the tests if you feel it is necessary)

Blocked By
@itsarune itsarune added the Difficulty - 7 Well-defined tasks that requires some understanding about the relevant system and tools label Jan 5, 2023
@raymond212 raymond212 self-assigned this Jan 14, 2023
@raymond212 raymond212 mentioned this issue Jun 10, 2023
Closed
4 tasks
@raymond212
Copy link
Contributor

Closing in favor of separate implementations of FreeKickPlay #2953 and KickoffPlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raymond212 raymond212

Labels
Difficulty - 7 Well-defined tasks that requires some understanding about the relevant system and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate single touch plays into OffensePlay raymond212/Software
2 participants
@itsarune @raymond212