Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to not save DNADesign in localStorage on every edit #348

Closed
dave-doty opened this issue Jul 6, 2020 · 4 comments · Fixed by #365
Closed

add option to not save DNADesign in localStorage on every edit #348

dave-doty opened this issue Jul 6, 2020 · 4 comments · Fixed by #365
Assignees
Labels
enhancement New feature or request

Comments

@dave-doty
Copy link
Member

On large designs (e.g., 25,000 strands), this causes a significant slowdown.

Here's the Chrome profiler on creating a nick in such a design:

image

Here's the same thing with writing to localStorage disabled:

image

As you can see, it adds about a 0.9 second delay.

@rishabhmudradi
Copy link
Collaborator

rishabhmudradi commented Jul 9, 2020

Should this feature be added under 'Edit' in the top menu?

@dave-doty
Copy link
Member Author

Let's put it under "File".

Note that this will require messing with the local_storage "middleware". Let me know if you want to chat about how that works.

@rishabhmudradi
Copy link
Collaborator

I think a short conversation might be helpful for me, I'm free anytime after 2 at your convenience.

@dave-doty
Copy link
Member Author

Closed in a8bf5cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants