Update to support newer releases and fix isolation variables

[SagarA17]

This MR aims to fix a few tool calls to support newer releases. The main changes however are in the lepton isolation variables -

1. The newer PHYS and LLP1 derivations now contain the closeByCorrected variables already written, which should then be used to calculate the isolation working points. There are corresponding changes to support this.
2. Older isolation variables are removed which might not even be written to the derivations anymore.

We also made some safeFill changes to track parameters in case they are not available in the derivations (which is often).

Thanks,
Sagar and @gfrattar

[mdhank]

Hello,

I tested out this update with my current setup (https://gitlab.cern.ch/atlassusy-bminusl/blcharginohlworkspace), using the sample

mc20_13TeV:mc20_13TeV.410472.PhPy8EG_A14_ttbar_hdamp258p75_dil.deriv.DAOD_PHYS.e6348_s3681_r13144_p5855
and AnalysisBase 24.2.20. I found it is crashing on the line https://github.com/SagarA17/xAODAnaHelpers/blob/new-isol-vars/Root/JetSelector.cxx#L767 . I am currently investigating why this is happening to see if any changes are needed (to the code or to my config). The error message is:

JetSelector.JetSelecto...DEBUG   Applying JVT SF
*** Break *** segmentation violation
[^[[1m2023-10-06 10:25:32,629^[[0m][^[[1;31mERROR^[[0m  ]  --------------------
An exception was caught! (^[[1mxAH_run.py^[[0m:656)
Traceback (most recent call last):
  File "/data/mhank/Penn_Analysis/BLstopWorkspace_Testing/blcharginohlworkspace/./source/xAODAnaHelpers/scripts/xAH_run.py", line 638, in <module>
    driver.submit(job, args.submit_dir)
cppyy.ll.SegmentationViolation: string EL::Driver::submit(const EL::Job& job, const string& location) =>
    SegmentationViolation: segfault in C++; program state was reset
[^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m   ]  ======================================== (^[[1mtiming.py^[[0m:22)
[^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m   ]  471279:25:32.630-End Program (^[[1mtiming.py^[[0m:23)
[^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m   ]  Elapsed time: 0:00:56.915 (^[[1mtiming.py^[[0m:25)
[^[[1m2023-10-06 10:25:32,631^[[0m][^[[1;37mINFO^[[0m   ]  ======================================== (^[[1mtiming.py^[[0m:26)
xAOD::TFileAccessTracer   INFO    Sending file access statistics to http://rucio-lb-prod.cern.ch:18762/traces/

Best,
Michael

[SagarA17]

Hello, Thanks for checking! I did not make any changes to the JetSelector, so I would think it’s an independent error not induced by us. Thanks, Sagar

…

On Fri, Oct 6, 2023 at 5:35 PM Michael Hank ***@***.***> wrote: Hello, I tested out this update with my current setup ( https://gitlab.cern.ch/atlassusy-bminusl/blcharginohlworkspace), using the sample mc20_13TeV:mc20_13TeV.410472.PhPy8EG_A14_ttbar_hdamp258p75_dil.deriv.DAOD_PHYS.e6348_s3681_r13144_p5855 and AnalysisBase 24.2.20. I found it is crashing on the line https://github.com/SagarA17/xAODAnaHelpers/blob/new-isol-vars/Root/JetSelector.cxx#L767 . I am currently investigating why this is happening to see if any changes are needed (to the code or to my config). The error message is: JetSelector.JetSelecto...DEBUG Applying JVT SF *** Break *** segmentation violation [^[[1m2023-10-06 10:25:32,629^[[0m][^[[1;31mERROR^[[0m ] -------------------- An exception was caught! (^[[1mxAH_run.py^[[0m:656) Traceback (most recent call last): File "/data/mhank/Penn_Analysis/BLstopWorkspace_Testing/blcharginohlworkspace/./source/xAODAnaHelpers/scripts/xAH_run.py", line 638, in <module> driver.submit(job, args.submit_dir) cppyy.ll.SegmentationViolation: string EL::Driver::submit(const EL::Job& job, const string& location) => SegmentationViolation: segfault in C++; program state was reset [^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m ] ======================================== (^[[1mtiming.py^[[0m:22) [^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m ] 471279:25:32.630-End Program (^[[1mtiming.py^[[0m:23) [^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m ] Elapsed time: 0:00:56.915 (^[[1mtiming.py^[[0m:25) [^[[1m2023-10-06 10:25:32,631^[[0m][^[[1;37mINFO^[[0m ] ======================================== (^[[1mtiming.py^[[0m:26) xAOD::TFileAccessTracer INFO Sending file access statistics to http://rucio-lb-prod.cern.ch:18762/traces/ Best, Michael — Reply to this email directly, view it on GitHub <#1659 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM4HOVXL7UL2NCLC732W6GLX6AQMLAVCNFSM6AAAAAA5USSSXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQHEZDKMBRGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mdhank]

Hello, I disabled all the usage of JVT, and was able to run, though I still get the warning:

METConstructor.METMake...WARNING No JetContainer set. This behaviour is deprecated

I agree this error is not from your changes, but fixing it may be necessary to fully support newer releases. I will continue looking into it. It's possible this is related to the rewrite of the JVT in https://gitlab.cern.ch/atlas/athena/-/merge_requests/64846 , which was implemented in 24.2.19. Best, Michael On Fri, Oct 6, 2023 at 11:52 AM Sagar Addepalli ***@***.***> wrote:

…

Hello, Thanks for checking! I did not make any changes to the JetSelector, so I would think it’s an independent error not induced by us. Thanks, Sagar On Fri, Oct 6, 2023 at 5:35 PM Michael Hank ***@***.***> wrote: > Hello, > > I tested out this update with my current setup ( > https://gitlab.cern.ch/atlassusy-bminusl/blcharginohlworkspace), using > the sample > > > mc20_13TeV:mc20_13TeV.410472.PhPy8EG_A14_ttbar_hdamp258p75_dil.deriv.DAOD_PHYS.e6348_s3681_r13144_p5855 > and AnalysisBase 24.2.20. I found it is crashing on the line > https://github.com/SagarA17/xAODAnaHelpers/blob/new-isol-vars/Root/JetSelector.cxx#L767 > . I am currently investigating why this is happening to see if any changes > are needed (to the code or to my config). The error message is: > > JetSelector.JetSelecto...DEBUG Applying JVT SF > *** Break *** segmentation violation > [^[[1m2023-10-06 10:25:32,629^[[0m][^[[1;31mERROR^[[0m ] -------------------- > An exception was caught! (^[[1mxAH_run.py^[[0m:656) > Traceback (most recent call last): > File "/data/mhank/Penn_Analysis/BLstopWorkspace_Testing/blcharginohlworkspace/./source/xAODAnaHelpers/scripts/xAH_run.py", line 638, in <module> > driver.submit(job, args.submit_dir) > cppyy.ll.SegmentationViolation: string EL::Driver::submit(const EL::Job& job, const string& location) => > SegmentationViolation: segfault in C++; program state was reset > [^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m ] ======================================== (^[[1mtiming.py^[[0m:22) > [^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m ] 471279:25:32.630-End Program (^[[1mtiming.py^[[0m:23) > [^[[1m2023-10-06 10:25:32,630^[[0m][^[[1;37mINFO^[[0m ] Elapsed time: 0:00:56.915 (^[[1mtiming.py^[[0m:25) > [^[[1m2023-10-06 10:25:32,631^[[0m][^[[1;37mINFO^[[0m ] ======================================== (^[[1mtiming.py^[[0m:26) > xAOD::TFileAccessTracer INFO Sending file access statistics to http://rucio-lb-prod.cern.ch:18762/traces/ > > Best, > Michael > > — > Reply to this email directly, view it on GitHub > < #1659 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AM4HOVXL7UL2NCLC732W6GLX6AQMLAVCNFSM6AAAAAA5USSSXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQHEZDKMBRGA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/UCATLAS/xAODAnaHelpers/pull/1659*issuecomment-1750969395__;Iw!!IBzWLUs!U0WScr6b8fsmB8vu2aw-Ohv5BwjRIZnuelPxHZklhb86TUrGYvhaQnPn04Va45h8CcEUsbobMyCMfUoajMnJVBeQzQ$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AHDGJVUW6M53HH6TJH5UKL3X6ASJ3AVCNFSM6AAAAAA5USSSXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQHE3DSMZZGU__;!!IBzWLUs!U0WScr6b8fsmB8vu2aw-Ohv5BwjRIZnuelPxHZklhb86TUrGYvhaQnPn04Va45h8CcEUsbobMyCMfUoajMluZcJx0A$> . You are receiving this because you commented.Message ID: ***@***.***>

[miholzbo]

Hello, @mdhank just pointed me to this PR. I've actually made some similar developments recently in the branch (the last four commits): https://github.com/miholzbo/xAODAnaHelpers/commits/dev/AB-updates

Overall, this PR seems to be much more advanced though. Could you try cherry-picking these commits into this PR? In particular the last one might be interesting to "re-solve" the Jvt issue for the moment.

[SagarA17]

Hello, @miholzbo. Thanks for the pointer! I have added the last commit to this PR as well. Hopefully, it solves the error/warning that @mdhank sees.

[mdhank]

I ran a test, and this does solve the error I was seeing! Thanks @SagarA17 and @miholzbo .

[SagarA17]

Thanks for checking @mdhank! Let me know what else I should look at before you are ready to merge.

[mdhank]

Hi @SagarA17 , I don't have merge permissions for xAH.

[SagarA17]

Maybe @kratsg could help us merge? We would appreciate the help!