Adding common PRW and mc23 PRW #1666
Conversation
Root/BasicEventSelection.cxx
Outdated
| prwConfigFiles.push_back(PathResolverFindCalibFile(m_prwActualMu2018File)); | ||
| if( !m_prwActualMu2022File.empty() && mcCampaign == "mc23a" ) | ||
| prwConfigFiles.push_back(PathResolverFindCalibFile(m_prwActualMu2022File)); | ||
| if( !m_prwActualMu2023File.empty() && mcCampaign == "mc23c" || mcCampaign == "mc23d" ) |
There was a problem hiding this comment.
I think this needs to be changed to (mcCampaign == "mc23c" || mcCampaign == "mc23d") otherwise the code crashed it the user doesn't specify a actual PRW file for 2023
There was a problem hiding this comment.
Thanks for catching this! I've fixed this, and allowed metadata to detect the campaign directly (note this should give a warning but still work if you use an out-of-date PRW such as mc23c).
There was a problem hiding this comment.
If I understand correctly, you can use the autoconfiguration of PRW files for mc23c if you manually specify the campaign as property via m_mcCampaign, otherwise you will run over mc23c but apply the PRW as it would be a mc23 file?
There was a problem hiding this comment.
My apologies, some of my commits didn't make it in - I've added them now. It should now detect mcCampaign from both run number and metadata- if it disagrees, it will use the latter, but with a warning.
mdhank
changed the title
Adding mc23a and mc23c cases for PRW auto-configuration. Also adding the option to use common PRW files for each MC campaign instead of DSID-specific files.