Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GSCDepth option for JetCalibrator #1683

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

mamerl
Copy link
Contributor

@mamerl mamerl commented Mar 26, 2024

Adding an additional option in JetCalibrator to allow the GSCDepth specified in a calibration config file to be overwritten with a user-specified value via m_calibGSCDepth. Implemented to only override GSCDepth when m_calibGSCDepth is not empty and GSC exists as a substring in the calibration sequence string.

@mamerl mamerl force-pushed the addGSCDepthToJetCalibrator branch from fab7069 to 4f12cfe Compare March 26, 2024 13:20
@mdhank
Copy link
Contributor

mdhank commented Mar 26, 2024

Hi @mamerl ,

For my knowledge, what does the GSCDepth option do? And what sort of value(s) are allowed?

Thanks,
Michael

@mamerl
Copy link
Contributor Author

mamerl commented Mar 26, 2024

Hi @mdhank,

GSCDepth controls which of the GSC steps get applied e.g. normally the ordering is chargedFraction->Tile0->EM3->nTrk->trackWIDTH->PunchThrough but for HLT jets we want to only do up to trackWIDTH since the information for the PunchThrough correction is not available for HLT jets.

The allowed values of GSCDepth are strings that can be any of "chargedFraction", "Tile0", "EM3", "nTrk", "trackWIDTH", "PunchThrough", or "Full" (same as "PunchThrough").

In Athena there is a check for the GSCDepth parameter to ensure it is valid at https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/Jet/JetCalibTools/Root/GlobalSequentialCorrection.cxx?ref_type=heads#L109. For now we just implemented the flag to pass the value to JetCalibrationTool and let the Athena tools handle the checks. If needed we can add some error checking though. What do you think is best?

Thanks,
Max

@mdhank
Copy link
Contributor

mdhank commented Mar 27, 2024

Thanks for the information! I think it's fine as is.

@mdhank mdhank merged commit 795f2c9 into UCATLAS:main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants