Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom menu links #10

Merged
merged 4 commits into from
Dec 10, 2018
Merged

Custom menu links #10

merged 4 commits into from
Dec 10, 2018

Conversation

cjg89
Copy link
Member

@cjg89 cjg89 commented Dec 10, 2018

Adds the ability to specify menu link items manually using inner shortcode contents. When inner [section-menu-item]'s are present with an enclosing [section-menu /] shortcode, automatic link generation won't occur. Section menus can still be generated automatically by including a [section-menu] shortcode with no inner contents.

Manually-added menu link items can be internal (anchors) or external. rel and new_window attributes are available to modify rel and target attributes on the generated links, respectively.

Examples:

Automatic menu items:

[section-menu]

Manually defined menu items:

[section-menu]
[section-menu-item href="#"]Some anchor[/section-menu-item]
[section-menu-item href="https://www.ucf.edu/"]An external link[/section-menu-item]
[/section-menu]

Also includes a fix in the section menu init js to generate default menu settings based on the #sections-menu element's data attributes, instead of .sections-menu.

Resolves #9.

@cjg89 cjg89 merged commit 9b9a001 into rc-v1.1.0 Dec 10, 2018
@cjg89 cjg89 deleted the custom-menu-links branch December 10, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants