Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self.build_stage wrong value in Site.__init__() #26

Open
cjlegg opened this issue Mar 28, 2023 · 2 comments
Open

self.build_stage wrong value in Site.__init__() #26

cjlegg opened this issue Mar 28, 2023 · 2 comments
Assignees
@cjlegg
Labels
bug Something isn't working fixed!

Comments

@cjlegg
Copy link
Contributor

cjlegg commented Mar 28, 2023

Points directly to build_stage/ sibling of spack site but this is now set in a config yaml - which should be read to find the value

Nothing yet uses this value - so effect is latent
@cjlegg cjlegg added the bug Something isn't working label Mar 28, 2023
@cjlegg cjlegg self-assigned this Mar 28, 2023
@cjlegg
Copy link
Contributor Author

cjlegg commented Mar 28, 2023

A difficulty with this is that spack config get returns the config with special vars (e.g. $spack) unexpanded - maybe it is better to delete this property of the Site class until it is needed

cjlegg pushed a commit that referenced this issue Apr 25, 2023
attempt fix bug on setting site.build_Stage
a8e0c07 
(issue #26) - read from site config.yaml
cjlegg pushed a commit that referenced this issue Apr 25, 2023
2nd attempt fix issue #26
5eeee40
@cjlegg
Copy link
Contributor Author

cjlegg commented Apr 25, 2023

fixed with commit 5eeee40
now using value of config.yaml/config/build_stage with $spack substituted with the dir of the site + 'spack'

@cjlegg cjlegg added the fixed! label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjlegg cjlegg

Labels
bug Something isn't working fixed!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjlegg