Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A starter readme. #3

Merged
merged 7 commits into from
May 2, 2023
Merged

A starter readme. #3

merged 7 commits into from
May 2, 2023

Conversation

samcunliffe
Copy link
Member

@samcunliffe samcunliffe commented Mar 14, 2023

Based on the Newcastle RSE groups project template with some totally untested cookiecutter fields.

@samcunliffe samcunliffe changed the base branch from start-cookieninja to main March 14, 2023 11:24

## Citation

Please cite [xx.yyy/zenodo.zzzz](https://doi.org/xx.yyy/zenodo.zzzzz) for this work if you use this code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this be in citation.cif instead, but let's do that later on

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CITATION.cff ^

Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@samcunliffe samcunliffe force-pushed the start-readme branch 2 times, most recently from 2d0ccc8 to 3678ac2 Compare March 14, 2023 12:15
[pypi-platforms]: https://img.shields.io/pypi/pyversions/{{cookiecutter.project_slug}}
[pypi-version]: https://img.shields.io/pypi/v/{{cookiecutter.project_slug}}
[rtd-badge]: https://readthedocs.org/projects/{{cookiecutter.project_name}}/badge/?version=latest
[rtd-link]: https://{{cookiecutter.project_slug}}.readthedocs.io/en/latest/?badge=latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question: should we keep all of this? We don't really recommend RTD over github pages so feels like we shouldn't make a choice here, but leave it to the user.

But then our cookie-cutter becomes very complicated: should we have "are you using GH discussions or slack?" and "are you using github pages or RTD?" type questions? Or just leave a lot of this commented out for the user to uncomment further down the line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would definitely be nicer to offer the option of github pabes vs rtd, but probably in a separate pr. Maybe remove the links for now?

And the PyPI badges could probably just be commented out and a comment added that says to uncomment once the package has been published

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed. Let's put that onto

@samcunliffe samcunliffe requested a review from p-j-smith May 2, 2023 09:54
cookiecutter.json Outdated Show resolved Hide resolved
@samcunliffe samcunliffe mentioned this pull request May 2, 2023
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have just had a quick glance

{{cookiecutter.project_slug}}/CITATION.cff Show resolved Hide resolved
@samcunliffe samcunliffe merged commit 8314e4e into main May 2, 2023
6 checks passed
@samcunliffe samcunliffe deleted the start-readme branch May 2, 2023 12:17
@samcunliffe
Copy link
Member Author

Your badges got eaten, sorry Paul.
... I'll open a "fix my mess" PR after my meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants