Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added HDF5 decoder #384

Merged
merged 1 commit into from
Feb 6, 2023
Merged

added HDF5 decoder #384

merged 1 commit into from
Feb 6, 2023

Conversation

wedeling
Copy link
Collaborator

@wedeling wedeling commented Feb 3, 2023

Added an HDF5 decoder, which is more flexible than the CSV decoder. Allows to load multiple QoIs of different size from the same HDF5 file. Syntax is the same as for the CSV decoder:

decoder = uq.decoders.HDF5(
    target_filename='output.hdf5',
    output_columns=['array_of_size10', 'array_of_size1000'])

New files:

  • easyvvuq/decoders/hdf5.py: the HDF5 decoder
  • test/test_decoder_hdf5.py: a test for the HDF5 decoder

This uses the h5py library, which I added to requirements.txt

@wedeling wedeling self-assigned this Feb 3, 2023
Copy link
Collaborator

@DavidPCoster DavidPCoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this adds significant functionality!

@djgroen
Copy link
Contributor

djgroen commented Feb 6, 2023

This adds an important functionality, with minimal risk to the rest of the code base. I don't see any obvious clashes with existing elements, and the code looks sound to me.

@wedeling wedeling merged commit 6dd5ec6 into dev Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants