Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/decrease needed memory (Issue 404) #405

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

DavidPCoster
Copy link
Collaborator

As described in #404, the PCE analysis code would sometimes use large amounts of memory. This pull request makes it possible to disable the calculation of the Correlation Matrices and Output Distributions. For one example, this decreased the memory usage to 2% of that previously required, and decreased the elapsed time to 12.7% of that previously required.

Copy link
Collaborator

@wedeling wedeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me

Copy link
Contributor

@djgroen djgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sensible and straightforward change.

@djgroen
Copy link
Contributor

djgroen commented Oct 1, 2023

I think this can be merged in, given that readthedocs is also broken in the main branch at the moment. We should try to fix that in the coming week imho.

@DavidPCoster
Copy link
Collaborator Author

Could someone with admin privileges on the repository look at why we are seeing

LGTM analysis: Python Expected — Waiting for status to be reported.                             Required
continuous-integration/travis-ci Expected — Waiting for status to be reported               Required 

with the status never being reported? I don't have sufficient access rights to do this myself!

@djgroen , @wedeling , ...

PS: readthedocs is no longer complaining after I committed a configuration file for it

@wedeling
Copy link
Collaborator

wedeling commented Oct 3, 2023

Could someone with admin privileges on the repository look at why we are seeing

LGTM analysis: Python Expected — Waiting for status to be reported.                             Required
continuous-integration/travis-ci Expected — Waiting for status to be reported               Required 

with the status never being reported? I don't have sufficient access rights to do this myself!

@djgroen , @wedeling , ...

PS: readthedocs is no longer complaining after I committed a configuration file for it

@DavidPCoster I gave you admin rights, you're basically one of the core maintainers at this point

@DavidPCoster DavidPCoster merged commit 0d27a63 into dev Oct 3, 2023
10 checks passed
@DavidPCoster DavidPCoster deleted the feature/decrease_needed_memory branch October 3, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants