Administration #725
Merged
Administration #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonygego
requested changes
Oct 8, 2021
anthonygego
reviewed
Oct 13, 2021
anthonygego
reviewed
Oct 13, 2021
anthonygego
requested changes
Oct 20, 2021
There was a problem hiding this comment.
I think this implementation can be lighter by removing some useless pieces of code.
There is an issue with displaying the bindings: the first one is displayed each time.
The performances in case of +2k users are terrible. Please add some random users in your local DB to test, and potentially do some pagination.
Drumor
force-pushed
the
administration
branch
2 times, most recently
from
68dda6a
to
632f046
Compare
|
Performance for +2k users are still terrible. A pagination system should be implemented. Maybe some parts of the submissions pagination mechanism can be refactored for other pages. |
Drumor
force-pushed
the
administration
branch
from
e2e1870
to
9c37171
Compare
anthonygego
requested changes
Dec 14, 2021
Drumor
force-pushed
the
administration
branch
from
e2a1502
to
c0353b4
Compare
Drumor
force-pushed
the
administration
branch
4 times, most recently
from
cc205d1
to
fd21cdc
Compare
anthonygego
requested changes
Jan 20, 2022
Drumor
force-pushed
the
administration
branch
from
fb19bcd
to
e1a28c2
Compare
Drumor
force-pushed
the
administration
branch
from
8bad73c
to
d8d8b0a
Compare
Drumor
requested review from
anthonygego
and removed request for
GuillaumeDerval
Drumor
force-pushed
the
administration
branch
from
39546c1
to
94e2707
Compare
anthonygego
reviewed
Feb 24, 2022
Drumor
force-pushed
the
administration
branch
from
94e2707
to
7687c2f
Compare
anthonygego
reviewed
Feb 24, 2022
Drumor
force-pushed
the
administration
branch
from
00c1b79
to
c3e724a
Compare
anthonygego
reviewed
Mar 10, 2022
anthonygego
reviewed
Mar 15, 2022
anthonygego
requested changes
Mar 18, 2022
There was a problem hiding this comment.
When you revoke a binding and get an error message for whatever reason, this error message is not cleaned when the modal box is closed.
Printing it in a red alert box instead of just displaying the message black on white would also be nice to better catch the user attention.
anthonygego
requested changes
Mar 23, 2022
anthonygego
requested changes
Mar 24, 2022
anthonygego
reviewed
Mar 25, 2022
anthonygego
approved these changes
Mar 30, 2022
Administration module - first features : Activate and delete a user Administration module - create user feature preparation Administration module - create user feature Administration module - base of bindings Administration module - base of bindings Administration module - base of bindings Admin - End revoke binding feature Admin - Use get_home_path for url call and clean html building Admin - makes template fit with already used system. Admin - rework INGIniousAdministratorPage Admin - fix ugly JS issue Admin - Some rework + INGIniousAdministratorPage review fix binding loop simplify workflow simplify workflow Avoid superadmin bypass remove add specific page - replace with modal make request of bindings more secure adding user paging based on submissions paging system move all hash generation to a method move all hash generation to a method solve superadmin check bypass fix double hash of password input make codacy happier optimize imports + give feedback rename and move hash password function move hash password function polish activate_user method Simplify feedback Update feedback improve users fetch move Marketplace link fix pagination center check activate status for several users Move JS into a dedicated file. Simplify ajax requests Move JS logic into dedicated file. improve feedback optimize imports review feedback use hash_password as class method remove useless verification in template display feedback when binding is not deletable Fixing remarks Handling all actions + gettext Adding "activated" field to UserInfo + Clean duplicate code + use dict comprehension Update docstring for get_users_info Set a behaviour for unknown action. Alert feedback more readable. fix bug with Keyerror Clean feedback on closing modal Set feedback display in a else statement Review user deletion and improve security. minimize list of selected courses to improve request and avoid bad logging. Minify Js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first implem of administration part. This lets admins create/delete/activate users. It's also possible to remove bindings for specific users.