sample_function_on_regular_grid uses the wrong sign for the offset in three places. #1178
Comments
KrisThielemans
pushed a commit
to KrisThielemans/STIR-1
that referenced
this issue
Apr 8, 2023
…locksOnCylindrical - Fixed inverse SSRB by always linearly interpolating between the two closest slices. This makes it work for BlocksOnCylindrical as well - Rework extend_* functions: new extend_segment function that works on more cases, deprecated others This works with BlocksOnCylindrical and view-offset. Fixes UCL#1177 - interpolate_projdata rewrite, including use linear interpolation in axial direction for BlocksOnCylindrical - Deprecate interpolate_axial_position which used nearest neighbour - Remove use_view_offset parameter from interpolate_projdata functions (always use view offset) - Fixed UCL#1178 offset handling in sample_function_on_regular_grid, add sample_function_using_index_converter - add test function - Updated release notes. Fixes UCL#1109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In function
sample_function_on_regular_grid, the offset is subtracted in one place and added in three places. The correct thing to do is to subtract it everywhere.The text was updated successfully, but these errors were encountered: