Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopted the same parallelisation used in back projection to avoid the… #1206

Conversation

markus-jehl
Copy link
Contributor

… clang thread safety problems in FBP2D.

@markus-jehl
Copy link
Contributor Author

Still need to look into FBP3D and why the tests are failing.

@KrisThielemans
Copy link
Collaborator

that seems to have worked! :-)

still want to do FBP3DRP before I merge?

@markus-jehl
Copy link
Contributor Author

Yay! I had a look at the FBP3D code and the 3D parts don't seem to use OpenMP, so it should be fine. The tests pass for me as well.

@KrisThielemans KrisThielemans linked an issue May 30, 2023 that may be closed by this pull request
@KrisThielemans KrisThielemans merged commit 3dfe828 into UCL:master May 30, 2023
5 checks passed
@markus-jehl markus-jehl deleted the issue/1190-openmp-in-fbp2d-not-thread-safe-with-clang branch January 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenMP parallelisation in FBP2D not thread safe with clang
2 participants