-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List-mode objective function: minor refactor and extra functionality #1418
List-mode objective function: minor refactor and extra functionality #1418
Commits on May 13, 2024
-
List-mode objective function: always uses OpenMP for gradient
- split caching in separate functions for reading a batch from list-mode file or cache - always use LM_distributable_computation for gradient Resulting code avoids duplication and is faster when caching is not used.
Configuration menu - View commit details
-
Copy full SHA for 9273703 - Browse repository at this point
Copy the full SHA 9273703View commit details -
use more local variables in LM_distributable_computation
The code pre-allocated bins for every thread, but local variables are allocated on the stack, which should take no time. Removing th epre-allocations simplifies the code, and prepares us for re-use for Hessian calculation etc
Configuration menu - View commit details
-
Copy full SHA for eca9c89 - Browse repository at this point
Copy the full SHA eca9c89View commit details -
prepare LM_distributable function for Hessian
- make list-mode loop into templated function - introduce separate functions for gradient and Hessian
Configuration menu - View commit details
-
Copy full SHA for 81c5b64 - Browse repository at this point
Copy the full SHA 81c5b64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c1fc00 - Browse repository at this point
Copy the full SHA 7c1fc00View commit details -
LM_listmode_function: implement Hessian and move functions
- move LM_distributable_function implementation to .txx as it now uses a template for the callback - implement actual_accumulate_Hessian... for LM - try to implement accumulation of log-likelihood WARNING: LM_distributable_computation is now generic and incompatible with the previous one (which was only for the gradient) Hessian function and log-likelihood value are currently untested/
Configuration menu - View commit details
-
Copy full SHA for cbf1999 - Browse repository at this point
Copy the full SHA cbf1999View commit details -
Configuration menu - View commit details
-
Copy full SHA for 233dead - Browse repository at this point
Copy the full SHA 233deadView commit details -
Add compute_gradient* (as opposed to only subset)
Also expand test to use all subsets, make it slower of course.
Configuration menu - View commit details
-
Copy full SHA for c296721 - Browse repository at this point
Copy the full SHA c296721View commit details -
Move common test to ObjectiveFunctionTests
test_PoissonLogLikelihoodWithLinearModelForMeanAndProjData and test_priors contained nearly similar code, so moved it to a new class. This needed minor modifications to the tests, but also addition of GeneralisedObjectiveFunction::compute_value()
Configuration menu - View commit details
-
Copy full SHA for f9d5d25 - Browse repository at this point
Copy the full SHA f9d5d25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6437d85 - Browse repository at this point
Copy the full SHA 6437d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92448a3 - Browse repository at this point
Copy the full SHA 92448a3View commit details -
LM obj-fun: add value() and tests
- compute_objective_function() is now implemented as well - Tests are (almost) a duplicate of the ProjData version, but gradient-test is disabled as for this sample data it is too slow
Configuration menu - View commit details
-
Copy full SHA for 7f6b2de - Browse repository at this point
Copy the full SHA 7f6b2deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 418c194 - Browse repository at this point
Copy the full SHA 418c194View commit details -
[GHA] upload ctest artefact if failure
Also update to upload-artefacts@v4
Configuration menu - View commit details
-
Copy full SHA for fe6bc39 - Browse repository at this point
Copy the full SHA fe6bc39View commit details
Commits on May 14, 2024
-
add "increment" test for gradient (enabled for LM data)
also minor clean-up
Configuration menu - View commit details
-
Copy full SHA for 267c161 - Browse repository at this point
Copy the full SHA 267c161View commit details -
[GHA] disabled LM objfunc test on MacOS
Cannot figure out what the problem is, but the test works on Ubuntu and Windows
Configuration menu - View commit details
-
Copy full SHA for 490771b - Browse repository at this point
Copy the full SHA 490771bView commit details