Fix/fragment ordering tc2 #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acholyn Sorry I just realised having running pre-commit and updated loads of files makes it really hard to see what's changed. Mostly models.base, models.antiquarians, models.work, and the migration file. |
acholyn
reviewed
Apr 25, 2023
acholyn
reviewed
Apr 25, 2023
| @@ -773,9 +773,6 @@ def test_testimonium_queryset_methods(self): | |||
| self.assertEqual(0, self.testimonium.definite_antiquarian_links().count()) | |||
| self.assertEqual(1, self.testimonium.possible_antiquarian_links().count()) | |||
|
|
|||
| @pytest.mark.skip( | |||
| "This can be revisited when definite status is broken down into ant/wk/bk" | |||
| ) | |||
| def test_add_antiquarian_fragment_ignores_work(self): | |||
There was a problem hiding this comment.
does this test pass for you then?
There was a problem hiding this comment.
Yes, but I had to fix a few things to do with testimonium ordering: basically put testimonia belonging to unknown works before those attached to other works (opposite to how it works for fragments and apposita)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include: