Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERV-888] Updates for IIIF Object Type column #233

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[SERV-888] Updates for IIIF Object Type column #233

merged 2 commits into from
Nov 16, 2023

Conversation

DRickard
Copy link
Member

Updates:

  • Add IIIF_OBJECT_TYPE constant to CSV.java
  • Update CsvHeaders.java to set/retrieve/verify new column
  • Update CsvParser.java to give preference to "IIIF Object Type" column (when it exists)
  • Add "IIIF Object Type" column to good.csv and headers_whitespace.csv for parsing tests
  • Add "IIIF Object Type" column to CsvParserTest.java tests
  • Created hathaway_iiif_type.csv for functional/integration test
  • Added test for handling "IIIF Object Type" column to PostCsvFIT.java

@DRickard DRickard requested a review from a team as a code owner November 15, 2023 22:09
Copy link
Member

@ksclarke ksclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

As we discussed in Slack, we can merge ignoring the Codacy complaint and I'm working on the Snyk issues in SERV-916.

@DRickard DRickard merged commit 0c60ab8 into main Nov 16, 2023
1 of 3 checks passed
@DRickard DRickard deleted the SERV-888 branch November 16, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants