[SERV-1068] Only set fallback thumbail on static images #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft since tests failed. I forgot I'd probably need to unwind some of those changes too. |
|
Now container packages need updating too. |
angelahuqing
previously approved these changes
Apr 8, 2024
angelahuqing
approved these changes
Apr 8, 2024
DRickard
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set thumbnails for images served by IIIF we'd have to supply the IIIF thumbnail dims, like we do in the v3 manifests. We've decided for now (cf ticket) to just not set those thumbnails, since we were not doing that before and the IIIF viewers know how to handle creating thumbnails when a specific one isn't included. This leaves the thumbnail to be set in v2 manifests only for the static images, where we have w/h supplied to the process via the CSV.