URS-843 Refactor Facets Modal CSS #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: app/assets/stylesheets/base/base.scss new file: app/assets/stylesheets/base/components/_facets-modal.scss modified: app/assets/stylesheets/base/components/_facets.scss modified: app/assets/stylesheets/legacy/ursus/_modal-header.scss new file: app/assets/stylesheets/theme_ursus/components/_ur-facets-modal.scss modified: app/views/catalog/_facet_pagination.html.erb modified: app/views_legacy/catalog/facet.html.erb modified: app/assets/stylesheets/base/base.scss new file: app/assets/stylesheets/base/components/_facets-modal.scss modified: app/assets/stylesheets/base/global/_buttons.scss modified: app/assets/stylesheets/base/utilities/_blacklight.scss new file: app/assets/stylesheets/base/utilities/old-css/old_blacklight/_modal.scss new file: app/assets/stylesheets/base/utilities/old-css/ursus/_modal-header.scss modified: app/assets/stylesheets/legacy/old_blacklight/_blacklight_base.scss deleted: app/assets/stylesheets/legacy/old_blacklight/_modal.scss modified: app/assets/stylesheets/legacy/ursus.scss deleted: app/assets/stylesheets/legacy/ursus/_modal-header.scss new file: app/assets/stylesheets/theme_ursus/components/_ur-facets-modal.scss modified: app/views/catalog/_facet_pagination.html.erb modified: app/views_legacy/catalog/facet.html.erb
jendiamond
approved these changes
Jun 17, 2020
jendiamond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor facets modal CSS to create default styling (See screenshots)
Set up Ursus CSS
Increase negative space between collection page metadata and second button
Archive unused/unneeded legacy Blacklight, Ursus and Sinai SCSS partials
modified: app/assets/stylesheets/base/base.scss
modified: app/assets/stylesheets/base/global/_buttons.scss
modified: app/assets/stylesheets/base/components/_facets.scss
modified: app/assets/stylesheets/base/utilities/_blacklight.scss
modified: app/assets/stylesheets/legacy/ursus.scss
modified: app/assets/stylesheets/legacy/old_blacklight/_blacklight_base.scss
modified: app/views/catalog/_facet_pagination.html.erb
modified: app/views_legacy/catalog/facet.html.erb
new file: app/assets/stylesheets/base/components/_facets-modal.scss
new file: app/assets/stylesheets/theme_ursus/components/_ur-facets-modal.scss
archived: app/assets/stylesheets/legacy/ursus/_modal-header.scss
archived: app/assets/stylesheets/base/utilities/old-css/old_blacklight/_modal.scss
archived: app/assets/stylesheets/base/utilities/old-css/ursus/_modal-header.scss