Merge branch 'release/2.4.4'

UCLATALL · Oct 21, 2021 · 3465a76 · 3465a76
2 parents 1edb631 + ae14115
commit 3465a76
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 23 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: supernova
 Type: Package
 Title: Judd, McClelland, & Ryan Formatting for ANOVA Output
-Version: 2.4.3
-Date: 2021-10-19
+Version: 2.4.4
+Date: 2021-10-20
 Authors@R: c(
     person(
       "Adam", "Blake", 

diff --git a/NAMESPACE b/NAMESPACE
@@ -63,7 +63,6 @@ export(ssr)
 export(superanova)
 export(supernova)
 export(variables)
-export(vec_arith.supernova_number)
 import(vctrs)
 importFrom(ggplot2,"%+%")
 importFrom(ggplot2,autoplot)

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# supernova 2.4.4
+
+* Remove `supernova-vctrs` from exports
+
 # supernova 2.4.3
 
 * Fix issues with `lintr` causing `R CMD CHECK` to fail

diff --git a/R/number.R b/R/number.R
@@ -1,8 +1,4 @@
-#' Internal `vctrs` methods
-#'
 #' @import vctrs
-#' @keywords internal
-#' @name supernova-vctrs
 NULL
 
 
@@ -152,10 +148,8 @@ vec_cast.supernova_number.character <- function(x, to, ...) {
 
 # Math ----------------------------------------------------------------------------------------
 
-#' @export
 #' @method vec_arith supernova_number
-#' @export vec_arith.supernova_number
-#' @rdname supernova-vctrs
+#' @export
 vec_arith.supernova_number <- function(op, x, y, ...) {
   UseMethod("vec_arith.supernova_number", y)
 }

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,17 @@
+*Previous reviewer asked for note explaining why package was removed:*
+Package was removed from CRAN because it was fixed too late (by a couple of hours) on Oct. 19. The
+problem was a recent bug in `lintr` that caused it to fail when running R CMD CHECK during the CRAN 
+build process. I implemented a workaround that is documented in the commit fixing the issue, if you 
+are interested.
+
+*Previous reviewer asked for additional documentation to `supernova-vctrs`*:
+This was not a usable function/class and is just a collection of methods making the package
+compatible with the `vctrs` package. I have removed `supernova-vctrs` from the exports.
+
+---
+
+# Original comments on release:
+
 ## Release summary
 
 * Fix issues with lintr causing R CMD CHECK to fail

diff --git a/inst/WORDLIST b/inst/WORDLIST
@@ -1,5 +1,6 @@
 Bonferroni
 Codecov
+codecov
 HSD
 McClelland
 PRE

diff --git a/man/supernova-vctrs.Rd b/man/supernova-vctrs.Rd