Add Friends With (deep)links #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPReplay_Final1612883124.MP4Friend doesn't show up after i add them |
|
@saachipahwa I think this is that state management issue, can you close & reopen the app and see if friend appears? |
|
Or just switch tabs to and from Network. |
|
Regardless, can you review the state mgmt PR first, I think that should fix some problems. |
saachipahwa
approved these changes
Feb 9, 2021
# Conflicts: # lib/main_pages.dart # lib/pages/add_friend_page.dart # lib/pages/sharing_page.dart
work when using provider.
|
Can you take another look? I made some non-trivial changes since last time. |
|
Yep it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115.
Here is the associated Figma.
@saachipahwa Can you check that it works on iOS, (especially the deeplink from website part)?