Share url through contacts + SMS #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good I'll test it tomorrow! Although what if they want to use Whatsapp or some other messaging app? |
|
@saachipahwa Currently I think they can already multi-send through whatsapp with the normal share button, unlike some of the other apps that you may use for sharing. |
|
Oh okay, then I think the button should be renamed to 'Share over SMS/text' |
Ok can you 'request changes' so I remember tomorrow when I see my email. |
saachipahwa
requested changes
Feb 13, 2021
|
For some contacts, it opens message but still doesn't send the text. For others, it doesn't open message at all. RPReplay_Final1613306231.2.MP4 |
|
Ok I think this is iOS being special as usual and not conforming to the SMS spec, I should be able to fix. |
|
@saachipahwa Can you try it now? |
|
Sharing deeplink over contacts works now |
saachipahwa
approved these changes
Feb 14, 2021
thevirtuoso1973
added a commit
that referenced
this pull request
Feb 22, 2021
* sentry * wb circle colour fix * comments and smaller shadow blur * theme colors in graph * fix bug and add test * P2P wellbeing sharing (#82) * implement keypair generation * implement private/public key to PEM, and fingerprint generation from public key * fix key generation by calling encode * POST new user to backend * use `compute` so screen doesn't hang * friend adding & basic outline of share UI * fix bug with user password * implement retrieving latest data * fix crypto, make list better * implement the friend_graph.dart * implement sending data to friend * implement seemingly working wellbeing sharing, add QR code * use FAB instead of button * add working refresh * fix rendering issue with QR camera * add stepper with working add_friend_page.dart * change to score so it fits screen * add sharing to QR with ShareButton * format and clean up * refresh automatically every 2 minutes * fix exception with graph & refresh * adding explicit view button * add unread data indication * add a TODO item * notify user of sent success & failure * display name instead of identifier * attempt to integrate with iOS * add container around QrImage to fix * send notification when new data received * remove unused notification * fix bug with unread indicator not showing * increment version * fix qr size Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com> * some cleanup, notably publish_screen.dart slipped through, even though I remember removing it from a previous conflict. * Coach mark timing (#106) * reducing time * remove testing stuff * fixing wb time * wait longer in case exeuction is slow * Settings page tests (#63) * initial tests: commented out shared prefs problem * settings page tests cleaning up * remove db stuff * test shared prefs by itself * change button * change buttons test * comments * current postcode and support tests * comment * fix for change postcode * remove constructors * Language changes 2 (#109) * steps nudge * intro language fixes * 'friend' to 'care network' * un-personifying app? * removing steps specific nudge * range change * remove low steps function * add to network * init notifications and check if data is from friend * fix multiple crypto setup, and add TODO * use ChartTitle to add left/right axis labels * add axes labels and split up a long string * add deeplink and share button that sends to BASE_URL * fix url, scaffold bug, and don't show/request camera permissions unless needed * set initialUri back to null once handled, add enum, and update version * fix null issue with _result * intro pg remove and settings show scheduled notif * small nudge page and sharing page changes * pod * coach mark issue * add test for add_friend_page_test.dart, mocking DB and ScaffoldState * fix null bug * order the friends list * check if user adding themselves, and write test for this * pass wellbeing record into home to fix state * extend ChangeNotifier and use provider for the DBs * use provider in sharing_page.dart * wbCheckTime * little fixes * pod * set state * past weeks to weeks * cleanup sharing_page.dart and .gitignore * req changes 2 * fixing home page coach mark * reducing time but still works * wrap provider around MaterialApp and fix tests * fix bug with infinite loading, although I don't see why sorting didn't work when using provider. * 400 coach mark * remove comment, pad left * Usability feedback (#119) * intro pg remove and settings show scheduled notif * small nudge page and sharing page changes * pod * coach mark issue * wbCheckTime * little fixes * set state * past weeks to weeks * req changes 2 * fixing home page coach mark * reducing time but still works * 400 coach mark * remove comment, pad left * update version * implement Comparable and sort before display * figma copy over and nudge notif * base url * center postcode caption * Use convex bottom bar (#130) * use convex bottom bar * colours Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com> * remove old code that was left in (#126) * Share url through contacts + SMS (#132) * add contact_share_page.dart and display contact * fix contact state * implement _sendToSelected, launch the sms URI * add comment on possible issue * change button text * use different separator depending on platform * remove duplicate yaml * try undocumented ios feature for multiple contacts * use flutter_sms plugin * null check on contact name and format * add custom scheme to Info-Debug.plist * lazy load contact avatar after initial retrieval (#139) * Polish (#133) * remove old code that was left in (#126) * small changes * sharing page description * remove comment * buttons to friends widget * change of key name, comment, * pod * scroll bar in intro screen * qr code description * button name change * pod * help button * QR scanner page subtitles * comment * launcher icon * settings page with sections * settings page test fix * fix coach mark mistake * pod * splash screen * underline see here and center notif selector * caption * formatting settings descriptions * network page updates * sharing page: colours, bold words, customscroll * remove custom scroll attempt * splash screen longer, nw button colours * home tutorial sized box fix * splash screen only shows when loading * make loadaftersplash neater * blue i button instead of ? button * version 1.3.0 * ios launch screen * pod * main logo font change -> KiteOne * launch screen * no more splash screen * settings page reformat * remove unused import * moving wb share button * smaller logo * remove launch screen * removec Future.value and print * Add linter stuff to dev branch (#147) * Create linter.yml * Add badge for linter * fix linter complaints, trailing spaces and headings * don't validate RUBY or JSCPD * remove check on push to dev Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com> * change linter setting * update workflows * use container with flutter * remove linter (too pedantic even for me) * change badge * fix badge * fix badge - third time's the charm * change name Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131. Can you see if it works on iOS?