Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement User Nudging #140

Merged
merged 23 commits into from
Feb 22, 2021
Merged

Implement User Nudging #140

merged 23 commits into from
Feb 22, 2021

Conversation

thevirtuoso1973
Copy link
Collaborator

@thevirtuoso1973 thevirtuoso1973 commented Feb 18, 2021

Partially closes #125.

This allows the user to send someone in their network a nudge to walk a certain amount of steps (up to 70,000). The receiver will receive a notification and can view their progress in the network page, which uses a custom UI painter and a bit of trigonometry to display the circular indication with a rotating image.
Once the receiver reaches their steps goal (which begins once they first receive the notification), they and the original sender will both receive notifications.

I would add a screenshot/gif but my phone doesn't have a step counter.

@thevirtuoso1973 thevirtuoso1973 added this to In progress in Implementation via automation Feb 18, 2021
@thevirtuoso1973 thevirtuoso1973 self-assigned this Feb 18, 2021
@thevirtuoso1973 thevirtuoso1973 marked this pull request as ready for review February 19, 2021 22:14
Copy link
Collaborator

@saachipahwa saachipahwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the picture of the person going around? I can't really tell that it is a person. Maybe not to birds eye view just a regular person

Copy link
Collaborator

@saachipahwa saachipahwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I send a goal from one phone to the other but it doesn't show up on the receiving phone

@thevirtuoso1973
Copy link
Collaborator Author

thevirtuoso1973 commented Feb 20, 2021

@saachipahwa Do both phones have this version? Also make sure you've reset it (i.e. gone through intro screen again).

@thevirtuoso1973
Copy link
Collaborator Author

thevirtuoso1973 commented Feb 20, 2021

Can you change the picture of the person going around? I can't really tell that it is a person. Maybe not to birds eye view just a regular person

Changed picture, haven't tested (cos I don't have access to device with step counter atm) but I had done it so it automatically resizes the input image so it should work.

@saachipahwa
Copy link
Collaborator

@saachipahwa Do both phones have this version? Also make sure you've reset it (i.e. gone through intro screen again).

Both phones had this version yeah and I think I did but I'll test again now

@saachipahwa
Copy link
Collaborator

The steps circle works great! Is there a way to make the person go clockwise instead of anticlockwise?

Also is there a delay on the 'someone sent you a steps goal' notification? It took quite a while.

@thevirtuoso1973
Copy link
Collaborator Author

thevirtuoso1973 commented Feb 21, 2021

Up to half an hour delay on the notifications, and maybe even more, it's up to the OS to display them.

On average it should be 15 minutes though.

@thevirtuoso1973
Copy link
Collaborator Author

@saachipahwa Can you send a gif/video here of the steps circle to show TA? Or you could do a live demo on Tues if you prefer.

@saachipahwa
Copy link
Collaborator

I shook the phone around and steps updated:
https://user-images.githubusercontent.com/55795994/108628127-f6197000-7450-11eb-8627-5a13b88993bd.mov

@thevirtuoso1973 thevirtuoso1973 merged commit e4fa449 into develop Feb 22, 2021
Implementation automation moved this from In progress to Done Feb 22, 2021
@thevirtuoso1973 thevirtuoso1973 deleted the p2p-nudge branch February 22, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants