Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Search to Contacts #159

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Add Search to Contacts #159

merged 3 commits into from
Feb 26, 2021

Conversation

thevirtuoso1973
Copy link
Collaborator

Closes #158.

@thevirtuoso1973 thevirtuoso1973 self-assigned this Feb 24, 2021
@thevirtuoso1973 thevirtuoso1973 added this to In progress in Implementation via automation Feb 24, 2021
@thevirtuoso1973 thevirtuoso1973 marked this pull request as ready for review February 24, 2021 13:59
@saachipahwa
Copy link
Collaborator

There are some exceptions/errors on the contacts page on ios. I'm running in release mode now so hopefully they show up on sentry

@saachipahwa
Copy link
Collaborator

Taking a closer look, I think it's just this one repeating.
flutter: Caught error: MissingPluginException(No implementation found for method getAvatar on channel github.com/clovisnicolas/flutter_contacts)
flutter: #0 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:157:7)

#1 MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:332:12)
#2 ContactsService.getAvatar (package:contacts_service/contacts_service.dart:76:16)
#3 _ContactSharePageState._updateAvatars. (package:nudge_me/pages/contact_share_page.dart:41:44)
#4 List.forEach (dart:core-patch/growable_array.dart:313:8)
#5 _ContactSharePageState._updateAvatars (package:nudge_me/pages/contact_share_page.dart:40:23)
#6 _ContactSharePageState.build. (package:nudge_me/pages/contact_share_page.dart:74:17)
#7 _FutureBuilderState.build (package:flutter/src/widgets/async.dart:751:55)
#8 StatefulElement.build (package:flutter/src/widgets/framework.dart:4744:28)
#9 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4627:15)
#10 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4800:11)
#11 Element.rebuild (package:flutter/src/widgets/framework.dart:4343:5)
#12 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2730:33)
#13 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:913:20)
#14 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:302:5)
#15 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1117:15)
#16 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1055:9)
#17 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:971:5)
#18 _rootRun (dart:async/zone.dart:1190:13)
#19 _CustomZone.run (dart:async/zone.dart:1093:19)
#20 _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#21 _invoke (dart:ui/hooks.dart:251:10)
#22 _drawFrame (dart:ui/hooks.dart:209:3)

@saachipahwa
Copy link
Collaborator

I didn't delete the previous version let me try that actually

@thevirtuoso1973
Copy link
Collaborator Author

Oh I can fix this.

@saachipahwa
Copy link
Collaborator

Same error is showing

@thevirtuoso1973
Copy link
Collaborator Author

Should be fixed now.

@saachipahwa saachipahwa merged commit e00f1a8 into develop Feb 26, 2021
Implementation automation moved this from In progress to Done Feb 26, 2021
@saachipahwa saachipahwa deleted the contacts-search branch February 26, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saachipahwa saachipahwa saachipahwa approved these changes

Assignees

@thevirtuoso1973 thevirtuoso1973

Labels
None yet
Projects
No open projects
Implementation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thevirtuoso1973 @saachipahwa