-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test #163
Add integration test #163
Conversation
@saachipahwa See the changed files in this PR. That settings page is weird, I didn't change it. Was that already there in develop? |
Had to change the backslashes to forward slashes to get it to recognise the files: flutter drive --driver=test_drive/integration_test.dart --target=integration_test/main_test.dart |
@saachipahwa Cool but the question marks? Was that there in develop already? We prob shouldn't merge until I know how it got there. |
there's no question marks on the develop branch |
@saachipahwa Very odd. Make sure you've pulled the latest integration test and develop code. Can you use the flutter inspector to check what widget that question mark is? I have attached a screenshot as an example of using the inspector. (Also this is how it looks on Android on the branch.) |
@saachipahwa Can you |
@saachipahwa Ok can you checkout develop and just add this package https://pub.dev/packages/integration_test to pubspec.yaml. Then run and see if it works as expected. |
There are no question marks when i add the package to develop and run |
Cool I think I know what the problem is then. |
No more question marks! |
* make some functions visibleForTesting * Add integration test (#163) * add example test * use multidex and add group of integration tests for intro_screen_test.dart * add integration test and home page test * add cupertino_icons back to pubspec * update lock * add pub key encoding test * check and add if should show tutorial * declare the type * add unit tests for crypto * Map link, text changes (#173) * 1 word changes * the change * to->by * bigger text and instructions on send nudge page * graph link * purple background settings tiles * expanded * increment version * add comments to main, main_pages & notification * Fix deprecation - use ScaffoldMessenger (#180) * use ScaffoldMessenger * upgrade provider * fix snackbar issue (and run formatting) * don't listen outside widget build * remove some TODOs * UI Improvements (#155) * add unread wellbeing data number to home page and nav bar * fix badgeMap type * use BoxShadow on home_page.dart * remove unread data from activity and animate score * remove unused, and pumpAndSettle tests * remove unused import * run formatting * add comments to background.dart * add comments to wellbeing_graph.dart * update home_page_test.dart, finding old text * format and add comments to friend_graph.dart * add example launch screen * add comments to friends_model.dart and user_model.dart * launch screen logo * hide testing page if in production * Update README.md (#186) Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com> * Ios launch screen (#183) * launch screen image * pod * launch screen * smaller logo picture * Pages documentation (#177) * settings sections * fixes * fix * sharing_page -> support_network * pages * app bar to top of scaffold * move comment up * buttons * fix * support page * bracket fix * connect comments * increment version * Android launcher (#190) * smaller logo? * smaller logo Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com>
* make some functions visibleForTesting * Add integration test (#163) * add example test * use multidex and add group of integration tests for intro_screen_test.dart * add integration test and home page test * add cupertino_icons back to pubspec * update lock * add pub key encoding test * check and add if should show tutorial * declare the type * add unit tests for crypto * Map link, text changes (#173) * 1 word changes * the change * to->by * bigger text and instructions on send nudge page * graph link * purple background settings tiles * expanded * increment version * add comments to main, main_pages & notification * Fix deprecation - use ScaffoldMessenger (#180) * use ScaffoldMessenger * upgrade provider * fix snackbar issue (and run formatting) * don't listen outside widget build * remove some TODOs * UI Improvements (#155) * add unread wellbeing data number to home page and nav bar * fix badgeMap type * use BoxShadow on home_page.dart * remove unread data from activity and animate score * remove unused, and pumpAndSettle tests * remove unused import * run formatting * add comments to background.dart * add comments to wellbeing_graph.dart * update home_page_test.dart, finding old text * format and add comments to friend_graph.dart * add example launch screen * add comments to friends_model.dart and user_model.dart * launch screen logo * hide testing page if in production * Update README.md (#186) Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com> * Ios launch screen (#183) * launch screen image * pod * launch screen * smaller logo picture * Pages documentation (#177) * settings sections * fixes * fix * sharing_page -> support_network * pages * app bar to top of scaffold * move comment up * buttons * fix * support page * bracket fix * connect comments * increment version * Android launcher (#190) * smaller logo? * smaller logo * watch performance while test runs Co-authored-by: saachipahwa <55795994+saachipahwa@users.noreply.github.com>
Closes #162. Maybe see if you can run the tests with iOS emulator/device following the added instruction in the README.md. It's not a huge problem if you can't cos this is more platform specific, and is just a bonus (widget tests are the real bread and butter).
@saachipahwa But definitely check if you can build/run the app normally on iOS, I had to change the Android build just to get the normal app to run after adding the integration_test library.
vlc-record-2021-02-27-16h52m04s-2021-02-27.16-47-48.mkv-.mp4