-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.8.0: Library Rewrite #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delegate requests in wrapper base to non-term requests only - requests using term now delegated to different struct - use builder for requests to allow for overriding requests
- also removed `need_waitlist` property from raw course info
- this gives us more flexibility when working with dynamically created strings.
- also refactored files so they're in appropriate places
- we needed to specify the header to CLOSE the connection
- also ensured trait methods didn't leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly restructures the library for more flexibility. Some major changes are highlighted below:
WebRegWrapperBuilder
to build a newWebRegWrapper
. You'll need to specify the term and cookies, but everything else (client, timeout, user agent) will assume default values.WebRegWrapper
structure won't directly support making requests to endpoints that require a term. Instead, users will need to callWebRegWrapper::make_request()
to create a builder instance, orWebRegWrapper::default_request()
to create a new request instance that can be used to create requests to WebReg endpoints.WebRegWrapper
object).Soon
To Be Completed
Use cargo's feature gate to give users the ability to enable or disable the wrapper (if the wrapper is disabled, make sure they can still access the parse functions and associated types).For a later release.