Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slider): add ratio, step to marks #59

Merged
merged 2 commits into from
Oct 30, 2018
Merged

feat(Slider): add ratio, step to marks #59

merged 2 commits into from
Oct 30, 2018

Conversation

ZxBing0066
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
No
What is the new behavior (if this is a feature change)?
add ratio to custom mark range width
add step to custom step in diff mark range
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

add ratio to custom mark range width
add step to custom step in diff mark range

fix #58
@ZxBing0066 ZxBing0066 added the feature New feature or request label Oct 29, 2018
@ZxBing0066 ZxBing0066 self-assigned this Oct 29, 2018
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #59 into master will increase coverage by 1.9%.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
+ Coverage   79.27%   81.18%   +1.9%     
=========================================
  Files         131      131             
  Lines        2244     2344    +100     
  Branches      538      557     +19     
=========================================
+ Hits         1779     1903    +124     
+ Misses        444      421     -23     
+ Partials       21       20      -1
Impacted Files Coverage Δ
src/components/Slider/style/index.js 100% <ø> (ø) ⬆️
src/components/Tooltip/Tooltip.jsx 90% <ø> (ø) ⬆️
src/components/Slider/Slider.jsx 94.8% <98.14%> (+53.29%) ⬆️
src/components/NumberInput/NumberInput.jsx 86.44% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fffced...42007cf. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit 717970f into master Oct 30, 2018
@ZxBing0066 ZxBing0066 deleted the slider branch October 30, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant