-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2.2.dev1] New MergedChoiceTable feature: from_df()
construction
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @mxndrwgrdnr! It will be great to finally have this. I completely agree with this approach, as we discussed in Slack. Here are some things i added just now:
If this all looks good, go ahead and merge! |
Looks great, Sam. Thanks for getting it across the finish line. |
from_df()
constructionfrom_df()
construction
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature we've wanted for a long time, the ability to create a MergedChoiceTable object from a dataframe. This gives the user the ability to create an mct using the standard choicemodels workflow, but to then extract it, manipulate it, add new terms, and cast it back to an object that can be used by urbansim_templates or choicemodels once again.
My goal was to make as few changes as possible to the core class structure, and as a result my solution is not the most elegant. It relies on the instantiation of two empty dataframes and a wrongly typed class attribute to satisfy what are currently required parameters of the MergedChoiceTable class. I'm open to suggestions if we think there's a better way to achieve the intended result.