Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering building costs on height #39

Open
pksohn opened this issue Mar 16, 2017 · 0 comments
Open

Filtering building costs on height #39

pksohn opened this issue Mar 16, 2017 · 0 comments

Comments

@pksohn
Copy link
Contributor

pksohn commented Mar 16, 2017

I'm confused about why fars gets filtered by the heights variable in this line in the pro forma model.

  • heights is a copy of the height column in the dev_info reference table. It's calculated from the FAR based on a parcel size of 10000 (the default value passed to parcel_sizes)
  • but it's compared to the max_height value for the parcels actually being tested
  • it seems like max_height should be compared to the height generated from the actual parcel size, not the default 10000.

This might be working correctly but I want to come back to this for clarification. This shows up in my example for class, in the 'surface' loop of _lookup_parking_cfg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant