Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that requires C++11 features #123

Merged
merged 1 commit into from Sep 2, 2019

Conversation

federicofernandez
Copy link
Contributor

@federicofernandez federicofernandez commented Sep 2, 2019

To allow compilation in Windows + Python 2.7 we need to remove the use of lambdas and std::function since is not supported in the msvc compiler version for 2.7.

Fixes: https://ci.appveyor.com/project/conda-forge/pandana-feedstock/builds/27034085/job/nwh0feurg1ijv0eu

@federicofernandez federicofernandez self-assigned this Sep 2, 2019
@federicofernandez federicofernandez changed the title Remove code that requires c++11. Remove code that requires C++11 features Sep 2, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.667% when pulling c6ccf12 on enhancement/remove-c++11 into 20b8724 on develop.

@smmaurer
Copy link
Member

smmaurer commented Sep 2, 2019

Thanks @federicofernandez!

One of the compilation flags in setup.py specifies std=c++11. Do you think we should change that? It might not matter; i think that's been there since before the changes that broke win-py27 compilation.

https://github.com/UDST/pandana/blob/enhancement/remove-c%2B%2B11/setup.py#L54

@federicofernandez
Copy link
Contributor Author

One of the compilation flags in setup.py specifies std=c++11. Do you think we should change that? It might not matter; i think that's been there since before the changes that broke win-py27 compilation.

I don't think is needed since those flags are used only for Linux / OSX. Anyway, the final test will be the compilation on Windows + 2.7, but I think it should work as is.

@federicofernandez federicofernandez merged commit a723ab4 into develop Sep 2, 2019
@federicofernandez federicofernandez deleted the enhancement/remove-c++11 branch September 2, 2019 17:37
@Eh2406
Copy link

Eh2406 commented Sep 2, 2019

Can we make sure the performance does not regress, that we still have the gains from #111?

@federicofernandez
Copy link
Contributor Author

Yes, no regressions, it's the same performance as #111, just with less elegant code, but more compatible.

@Eh2406
Copy link

Eh2406 commented Sep 3, 2019

Thanks for double checking!

smmaurer added a commit that referenced this pull request Dec 22, 2020
@smmaurer smmaurer mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants