Fixing matplotlib backend #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmaurer
force-pushed
the
fix-matplotlib-backend
branch
from
f99880f
to
09167d2
Compare
|
When is this due for release on to master? I'm just trying to update my docker image for next year's teaching and would love to have this fix available to install/update via the main conda-forge channel or pip. Or is there a dev tag that should use? Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #132, where a hardcoded Matplotlib setting was creating problems for downstream code. As far as I can tell, the setting was just an old attempt to make Travis tests run more smoothly and is no longer needed.
Testing
Confirmed that this fixes the problem, as described here: #132 (comment)