Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions #153

Merged
merged 40 commits into from Dec 8, 2020
Merged

GitHub Actions #153

merged 40 commits into from Dec 8, 2020

Conversation

smmaurer
Copy link
Member

@smmaurer smmaurer commented Dec 8, 2020

This PR moves the automated testing from Travis and AppVeyor to GitHub Actions. This lets us break up the tests into clearer and more modular chunks. GitHub is also running them much faster.

We'd like to gradually move all the UDST repos over to this model. Pandana is the first.

Tests running on GitHub Actions

On push:

  • check code style
  • run unit tests in a single generic environment (ubuntu-py38)

On PR:

  • generate a coverage report
  • run unit tests in a range of python versions and operating systems

Weekly:

  • install Pandana from Pip and Conda in a range of environments, to catch dependency updates that break Pandana

Other changes in this PR

  1. Updates a testing setting that skipped certain tests on Travis -- now skips them on any CI system.

  2. Drops the MACOSX_DEPLOYMENT_TARGET environment variable from the installation script. This has been in there for years and occasionally causes problems on certain systems -- including the GitHub Actions macos-latest image. It doesn't seem necessary to set a specific value any more. (Tested in 10.15 Catalina, 11.0 Big Sur, and GitHub Actions macos-latest.)

There are a zillion commits here, because I was learning how GitHub Actions works, so I'll do a squash merge.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.886% when pulling c866c0f on github-actions into 20af9a5 on dev.

Copy link
Collaborator

@sablanchard sablanchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@smmaurer smmaurer merged commit 9fca283 into dev Dec 8, 2020
@smmaurer smmaurer deleted the github-actions branch December 11, 2020 22:06
@smmaurer smmaurer mentioned this pull request Mar 17, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants