Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 support #64

Merged
merged 13 commits into from
Apr 3, 2017
Merged

Python3 support #64

merged 13 commits into from
Apr 3, 2017

Conversation

federicofernandez
Copy link
Contributor

A couple of modifications were done to support Python 3.x. It was tested with Python 3.5 and Python 2.7 for backwards compatibility, running the full set of tests of the library.

It's difficult to guarantee that no performance differences were introduced, but functionality seems not to be affected.

Federico J. Fernandez added 2 commits March 20, 2017 17:31
Changes to support Python3
15ba67d 
This includes the changes in the way the C extensions are declared and
changes in Python itself.
Struct needed in Python 2.x too
357fa7a
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 87.569% when pulling 357fa7a on python3-support into 2c1ba48 on master.

@fscottfoti
Copy link
Contributor

Awesome.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 88.372% when pulling aa0709b on python3-support into 2c1ba48 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 88.372% when pulling aa0709b on python3-support into 2c1ba48 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.372% when pulling e24acd4 on python3-support into 3e93c38 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.372% when pulling d811ac2 on python3-support into 3e93c38 on master.

@coveralls
Copy link

coveralls commented Mar 31, 2017 •
edited

Coverage Status

Coverage remained the same at 88.372% when pulling 42f75e2 on python3-support into 3e93c38 on master.

@coveralls
Copy link

coveralls commented Mar 31, 2017 •
edited

Coverage Status

Coverage remained the same at 88.372% when pulling 42f75e2 on python3-support into 3e93c38 on master.

Federico J. Fernandez added 2 commits March 31, 2017 13:47
Migrating from PEP8 to pycodestyle
ce36f4a 
Since pycodestyle is much more comprehensive, we are changing the tool
used for enforcing coding style.
Code quality improvements
c10dc9d 
Suggested by pycodestyle.
@coveralls
Copy link

coveralls commented Mar 31, 2017 •
edited

Coverage Status

Coverage remained the same at 88.372% when pulling c10dc9d on python3-support into 3e93c38 on master.

@coveralls
Copy link

coveralls commented Mar 31, 2017 •
edited

Coverage Status

Coverage remained the same at 88.372% when pulling d1da7f6 on python3-support into 3e93c38 on master.

@coveralls
Copy link

coveralls commented Mar 31, 2017 •
edited

Coverage Status

Coverage remained the same at 88.372% when pulling d1da7f6 on python3-support into 3e93c38 on master.

Changing version to 0.3.0
a2eff32 
Given that the changes after 0.2 are many and important, we decided to
name this version as 0.3.0 instead of 0.2.1.
@coveralls
Copy link

coveralls commented Mar 31, 2017 •
edited

Coverage Status

Coverage remained the same at 88.372% when pulling a2eff32 on python3-support into 3e93c38 on master.

@federicofernandez federicofernandez merged commit 729b2bc into master Apr 3, 2017
@federicofernandez federicofernandez deleted the python3-support branch April 4, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksohn pksohn pksohn approved these changes

@sablanchard sablanchard Awaiting requested review from sablanchard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@federicofernandez @coveralls @fscottfoti @pksohn