Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pandas sort methods #197

Merged
merged 1 commit into from
May 9, 2017
Merged

Update Pandas sort methods #197

merged 1 commit into from
May 9, 2017

Conversation

pksohn
Copy link
Contributor

@pksohn pksohn commented May 9, 2017

As mentioned in #196, Pandas 0.20 drops the sort methods for DataFrames and Series, so we have to replaced with sort_values in a couple of places. Other things:

  • Bumped required Pandas version to 0.17, which is the first version with sort_values
  • Bump UrbanSim version for bugfix release

federicofernandez
federicofernandez approved these changes May 9, 2017
View reviewed changes
Copy link
Contributor

@federicofernandez federicofernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@federicofernandez federicofernandez merged commit a14b287 into master May 9, 2017
@pksohn pksohn mentioned this pull request May 9, 2017
Closed
@pksohn pksohn deleted the sort_bug branch May 9, 2017 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicofernandez federicofernandez federicofernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pksohn @federicofernandez