[0.2.dev5] Template for column from expression #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apdjustino
reviewed
Mar 14, 2019
|
|
||
| """ | ||
| if self.column_name is None: | ||
| raise ValueError("Please provide a column name") |
There was a problem hiding this comment.
This line uses double quotes but there are single quotes in other parts of the file. In the future we can use pylint to ensure uniform code style.
There was a problem hiding this comment.
I use double quotes for natural-language messages and single quotes for strings that are more like data, i think. Not sure if this is a standard or just a habit i picked up, though! We can see what pylint wants.
| raise ValueError("Please provide a column name") | ||
|
|
||
| if self.table is None: | ||
| raise ValueError("Please provide a table") |
| raise ValueError("Please provide a table") | ||
|
|
||
| if self.expression is None: | ||
| raise ValueError("Please provide an expression") |
smmaurer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a template to register a column of derived data with Orca, based on an expression. This is the first use case from issue #98.
New template
urbansim_templates.data.ColumnFromExpression()The expression is passed to
df.eval()and can refer to other columns in the same table, including stand-alone columns that have not yet been evaluated. It supports arithmetic and math functions including sqrt, abs, log, exp, log1p, and expm1.More info about the expression parsing:
Template-specific parameters:
column_nametableexpressiondata_type(optional)missing_values(optional)cache(optional)cache_scope(optional)Versioning
To do before merging
run()method