-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.1.dev18] Installation improvements and continuous integration #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates into travis-setup
smmaurer
changed the title
Setup and continuous integration
Installation improvements and continuous integration
Nov 7, 2018
Closed
smmaurer
changed the title
Installation improvements and continuous integration
[0.1.dev17] Installation improvements and continuous integration
Nov 9, 2018
smmaurer
changed the title
[0.1.dev17] Installation improvements and continuous integration
[0.1.dev18] Installation improvements and continuous integration
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves installation and testing.
Moves requirements out of
setup.py
and into their own file(s). This allows a single list of requirements to be used for pip environments, conda environments, and in the setup script.Divides dependencies into (a) minimal requirements for model management and core templates, (b) additional requirements for less-used templates, and (c) requirements for development and testing. This is a common design pattern (e.g. pandas uses it) to avoid dependency bloat, keeping installation as fast and reliable as possible.
But this means we need to help out users who might be missing dependencies for certain template functionality. Following pandas, I've moved the relevant
import
statements inside try-catch blocks that raise clear errors telling users what's going on and how to resolve it.(We can use the same strategy for imports that often have version compatibility problems, like the
choicemodels
development releases that are currently required by the Large MNL template.)Adds a Travis script to automatically run the test suite across python versions when commits are pushed to Github.
Incidentally, it seems like the templates work fine in Python 2.7 -- i hadn't tested this until putting together the Travis builds.
Updates the README. More substantial documentation improvements coming separately.
Versioning
Updates the library version to 0.1.dev18
Before merging:
pylogit