Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.1.dev23] automatically add interaction term table indices to list of columns r… #77

Merged
merged 4 commits into from
Dec 14, 2018

Conversation

mxndrwgrdnr
Copy link
Member

…equired to generate merged choice table object.

The only tricky thing about this PR is that it requires the indices of a multi-indexed table of interaction terms to have the indices ordered, with the index corresponding to the observations table as the outermost or first index, and the the index corresponding the the alternatives table is the second or innermost index. I have updated the docstrings accordingly in the large_multinomial_logit.run() method, and also in the choicemodels.tools.mergedchoicetable constructor in a PR here.

@coveralls
Copy link

coveralls commented Dec 14, 2018

Pull Request Test Coverage Report for Build 98

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 89.709%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/UDST/urbansim_templates/urbansim_templates/models/large_multinomial_logit.py 6 94.02%
Totals Coverage Status
Change from base Build 91: -0.1%
Covered Lines: 985
Relevant Lines: 1098

💛 - Coveralls

Copy link
Member

@smmaurer smmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@mxndrwgrdnr mxndrwgrdnr merged commit dab0b4d into master Dec 14, 2018
@mxndrwgrdnr mxndrwgrdnr deleted the add_intx_term_cols_to_xtra_cols branch December 14, 2018 01:00
@smmaurer smmaurer changed the title automatically add interaction term table indices to list of columns r… [0.1.dev13] automatically add interaction term table indices to list of columns r… Dec 17, 2018
@smmaurer smmaurer changed the title [0.1.dev13] automatically add interaction term table indices to list of columns r… [0.1.dev23] automatically add interaction term table indices to list of columns r… Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants