-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag Best Country ties better #283
Comments
Tournament.best_countries(whole_list=False) does correctly handle ties. |
The awards view doesn't have its own code at the moment - it uses tournament_views.tournament_simple(). I don't see an easy way to detect a shared award from within the template. |
I wonder if we should be storing the player's rank in their RoundPlayer and TournamentPlayer (and potentially GamePlayer, too). It only changes when Game scores change, and having it there makes it accessible to the template code. We could also add a rank_tied attribute... |
In which case we could also add a best_power_rank to GamePlayer (and potentially best_power_rank_tied). |
Of course none of that helps with awards. I think the only way to deal with that is to have an actual class linking the Award to the TournamentPlayer, which can then have an is_shared attribute or method. |
This now has a bunch of potential improvements, so let's try to capture them all:
|
tournament_best_countries() calls Tournament.best_countries(whole_list=True), which doesn't flag ties. For each power, it returns an ordered list of GamePlayers, but some of those may be ties. It can identify ties by looking at the scores. |
Change the list returned by Tournament.best_countries(hole_list=True) to be a list of lists, with each sub-list containing the GamePlayers at a given rank, thus clearly identifying ties. Change the corresponding view code and template to process the list accordingly. Issue #283
The commit fixes (1). |
Created issue #288 to cover (4) |
Where two players have the same score as the same power, need to make that clearer on the "Best Countries" page. May want to support automatic tie-breaks. We do now have the ability for the TD to pick who gets the actual award, so that should be reflected in the view.
The text was updated successfully, but these errors were encountered: