Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sudo apt-get install -y portaudio19-dev " does not work on travis... Do we need it? #73

Closed
oplatek opened this issue Oct 3, 2014 · 5 comments

Comments

@oplatek
Copy link
Member

oplatek commented Oct 3, 2014

Do we need portaudio19-dev for unit tests?
Do we need portaudio19-dev for integration tests?
Do we need it at all?
...
I guess not -> Can I remove it from dependencies?

@ticcky
Copy link
Contributor

ticcky commented Oct 3, 2014

Does pyaudio compile without that?

@oplatek
Copy link
Member Author

oplatek commented Oct 6, 2014

No, it does not compile without portaudio.
What for do we need pyaudio?... for integration tests, right?

@jurcicek
Copy link
Member

jurcicek commented Oct 6, 2014

pyaudio is used in AIO and AIO is used in some test scripts.

Otherwise, I do not care about input from a soundcards. I prefer VOIP.

Best regards,
Filip Jurcicek


Work tel. (CZ): +420221914402
Personal tel. (CZ): +420777805048
Skype: bozskyfilip

http://ufal.mff.cuni.cz/filip-jurcicek
http://ufal.mff.cuni.cz/grants

On 6 October 2014 07:01, Ondrej Platek notifications@github.com wrote:

No, it does not compile without portaudio.
What for do we need pyaudio?... for integration tests, right?


Reply to this email directly or view it on GitHub
#73 (comment).

@ticcky
Copy link
Contributor

ticcky commented Oct 6, 2014

OK. So I guess we should change the code so that pyaudio will get imported only in those scripts, and we can remove this requirement from the global ones.

@oplatek
Copy link
Member Author

oplatek commented Feb 13, 2015

Fixed by cleaning in (and around) commit e81f6fe

@oplatek oplatek closed this as completed Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants