Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom chip group counter #1197

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Add custom chip group counter #1197

merged 3 commits into from
Mar 10, 2023

Conversation

albinmedoc
Copy link
Contributor

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

basbruss
basbruss reviewed Mar 7, 2023
View reviewed changes
custom_cards/custom_chip_group_counter/README.md

# Custom Card "Group Counter"

![example-image-light](../../docs/assets/img/custom_card_group_counter_chip_light.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path doesn't exist

custom_cards/custom_chip_group_counter/README.md

## Variables

| Variable | Default | Required | Notes |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table doesn't display as supposed to

@albinmedoc
Copy link
Contributor Author

I have now fixed the issues.

@basbruss basbruss merged commit 2559e89 into UI-Lovelace-Minimalist:main Mar 10, 2023
@albinmedoc
Copy link
Contributor Author

I can't find my custom chip on the website.
Should I make a new PR and add the documentation there as well, or is this something you will do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basbruss basbruss basbruss approved these changes

Assignees
No one assigned
Labels
💡 custom feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albinmedoc @basbruss