Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework and Refinements to 'custom_card_sisimomo_printer' #1223

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Rework and Refinements to 'custom_card_sisimomo_printer' #1223

merged 8 commits into from
Apr 3, 2023

Conversation

ellisdickinson46
Copy link
Contributor

@ellisdickinson46 ellisdickinson46 commented Mar 23, 2023

Additional information

This PR is intended to address some of the issues I have faced with the current version of custom_card_sisimomo_printer. It has been changed, in short, to improve styling and coherence with other cards and add support for tricolor cartridges. Some other small improvements have also been made.

It does not address any open issue at the time of submission.

Changelog

  • Added support for other cartridge types (tricolor)
  • Added further error checking for previously uncaught states
  • Added support for the IPP 'unavailable' state
  • Added CSS for better theming of error screens
  • Added card string translation files
  • Changed text-transform of label to capitalize
  • Changed ulm_unavailable to ulm_translation_unavailable
  • Removed some unnecessary inline stylings
  • Fixed the handling of unavailable and idle state styling

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

@ellisdickinson46 ellisdickinson46 marked this pull request as ready for review March 24, 2023 00:15
@basbruss basbruss merged commit 458585d into UI-Lovelace-Minimalist:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants