Favorite Button and Horizontal Fix

[benbur98]

Have added a Favorites button to the card:

Have also fixed the Horizontal mode display to display multiple options if selected:

This PR fixes or closes issue: fixes #1215 and #1251
This PR is related to issue:
Link to documentation pull request:
Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
  I have followed the contribution guidelines
  This PR is for a custom-card or documentation change and therefore directed to the main branch.
• This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

[benbur98]

As in issue #1215, changes to the horizontal mode to allow a 'priority' item are planned. I think it makes sense to have a separate PR for this as changes will likely be consistent on other cards too. This PR is hence ready for review/merge.

[basbruss]

The only problem I see for now is that if enable_tilt is set the slider is on the top line.
And what should be the placement if enable_slider, enable_tilt, and enable_controls are all set?

[benbur98]

@basbruss thanks for having a look, I've thought the same thing. I personally don't really have a preference of the order.

I don't know the best way for this to work (currently it's just in one order - buttons, slider, tilt)... open to ideas

[shift-del1]

@benbur98 @basbruss My recommendation would be the following:

• define a default order for the controls, like
  • slider
  • movement control
  • tilt control
• use the variable"horizontal" to pick one element from the list (so not a true/false anymore, but a given value), which should be removed from the vertical stack and be placed inline with the name/label
  Do you think it would make sense?

[benbur98]

@shift-del1 I've implemented this as you've suggested in the last comment. Personally I think it's a little clumsy so will think about how best to do it in the future (this will be common across other cards too so need some common solution).

[shift-del1]

Thank you. This was just my idea, but I'm open for anything else better :-)

[dankarization]

After this "fix" it is impossible to get a card without controls, but with slider and 1 unit of height

  - type: "custom:button-card"
    template: card_cover
    entity: cover.drivent_453
    variables:
      ulm_card_cover_enable_controls: false
      ulm_card_cover_enable_slider: true
      ulm_card_cover_enable_horizontal: true
      ulm_card_cover_gate: false
      ulm_card_cover_garage: false

This is my previous configuration, getting me smth like the 2nd photo, but without tilt buttons at the bottom.

[benbur98]

For this, changing ulm_card_cover_enable_horizontal: true -> ulm_card_cover_enable_horizontal: slider should allow this - it will set the slider as the priority horizontal element in the card. Maybe overlooked this change as a breaking change...

[dankarization]

Yep, changing true to slider helped, thx. This was not obvious at all, since all other parameters takes boolean inputs